Commit Graph

33188 Commits

Author SHA1 Message Date
Andy Balaam da2471ffbd Fix a crash when removing persistent widgets (updated) (#10099)
* Fix a crash when removing persistent widgets

When a persistent widget is removed, multiple calls to updateShowWidgetInPip happen in succession as each of the widget stores emit updates. But by depending on this.state.persistentWidgetId at the time of the call rather than passing an update function to setState, this had the effect that the removal of the widget could be reverted in the component's state, and so it could end up passing the ID of a removed widget to WidgetPip.

* Re-public updateShowWidgetInPip so we don't change the interface

---------

Co-authored-by: Robin Townsend <robin@robin.town>
2023-02-07 11:14:19 +00:00
Florian Duros 4c7945552c Merge branch 'develop' into unread-title-indicator 2023-02-07 11:37:34 +01:00
Michael Telatynski 54a6ce589f Fix wrongly grouping 3pid invites into a single repeated transition (#10087) 2023-02-07 10:09:46 +00:00
Michael Telatynski 35d222bac6 Add @typescript-eslint/no-base-to-string (#10091) 2023-02-07 10:08:10 +00:00
Michael Weimann 4648fa3c8c Add PiP move threshold (#10040) (#10033) 2023-02-07 10:14:28 +01:00
Suguru Hirahara 5ac014ff29 Add a whitespace character after 'broadcast?' (#10097)
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2023-02-07 09:09:44 +01:00
Michael Weimann 39fe72e53a Fix broadcast pip seekbar (#10072) 2023-02-06 13:15:20 +01:00
Richard van der Hoff 5ba8ecabb5 Element-R: fix rageshages (#10081)
quick hacks to get rageshakes working in element R

Fixes https://github.com/vector-im/element-web/issues/24430
2023-02-06 10:50:34 +00:00
Gustavo Santos d4349bb361 Add border to 'reject' button on room preview card (#9205)
* Add border to 'reject' button on room preview card

Signed-off-by: gefgu <gefgu@hotmail.com>

* feat: use correct kind

---------

Signed-off-by: gefgu <gefgu@hotmail.com>
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
2023-02-06 10:50:06 +00:00
Tim Tills 73c2f42177 Indicate unread rooms in document.title
Signed-off-by: Tim Tills <tnt7864@rit.edu>
2023-02-05 21:31:16 -05:00
Andy Balaam a756b33fe9 Rename RoomCreate -> RoomPredecessorTile (#10047) 2023-02-03 16:58:52 +00:00
Florian Duros 2b66cfc25f Open message in editing mode when keyboard up is pressed (RTE) (#10079)
Move to previous message when arrow up is pressed in the main composer (RTE)
2023-02-03 17:43:02 +01:00
Janne Mareike Koschinski f1a08cd572 Gitter sunsetting: Use findPredecessor in EventTileFactory (#10075) 2023-02-03 15:36:37 +00:00
Michael Telatynski 9743852380 Improve typescript null checking in places (#10073 (#10073
* Improve typescript null checking in places

* Iterate

* Fix Timer.ts
2023-02-03 15:27:47 +00:00
Michael Weimann 97506cbcdb Migrate SpotlightDialog for dynamic room predecessors (#10076) 2023-02-03 15:47:07 +01:00
Andy Balaam add23e4d5d Pass the dynamic predecessor feature flag when listing rooms (#10068) 2023-02-03 14:09:31 +00:00
Michael Weimann cfba1b07c6 Broadcast time left should never be negative (#10070) 2023-02-03 13:49:43 +01:00
Michael Weimann 27bd04a875 Use findPredecessor in RoomNotifs#getUnreadNotificationCount (#10067) 2023-02-03 13:00:33 +01:00
Germain 6dd578e5a7 Devtools for stuck notifications (#10042) 2023-02-03 11:07:24 +01:00
Florian Duros 469228f45e Fix new line created when enter is pressed (#10064) 2023-02-03 10:48:12 +01:00
Andy Balaam b7cd28bd29 Support MSC3946 in RoomListStore (#10054) 2023-02-03 09:14:44 +00:00
Michael Telatynski 2bde31dcff Switch to linkify-react for element Linkification as it handles React subtrees without exploding (#10060
* Switch to linkify-react instead of our faulty implementation

Fixes a series of soft crashes where errors include "The node to be removed is not a child of this node."

* Improve types

* Fix types

* Update snapshots

* Add test

* Fix test
2023-02-03 08:59:21 +00:00
Michael Weimann 089557005a Autofocus security key field (#10048) 2023-02-03 09:39:25 +01:00
Kerry ebb8408f28 Poll history - read only list of polls in current timeline (#10055)
* add settings while under development

* very basic tests for roomsummarycard

* empty poll history dialog and option in room summary

* pollS history in settings

* render an ugly list of polls in current timeline

* readonly poll history list items

* fix scroll window

* use short year code in date format, tidy

* no results message + tests

* strict fix

* mock intldatetimeformat for stable date formatting

* extract date format fn into date-utils

* jsdoc
2023-02-02 21:39:23 +00:00
Kerry 544baa30ed use Poll model with relations API in poll rendering (#9877)
* wip

* remove dupe

* use poll model relations in all cases

* update mpollbody tests to use poll instance

* update poll fetching login in pinned messages card

* add pinned polls to room polls state

* add spinner while relations are still loading

* handle no poll in end poll dialog

* strict errors

* strict fix

* more strict fix
2023-02-02 20:22:26 +00:00
Johannes Marbach f3fd027db4 Merge branch 'develop' into johannes/latest-room-in-space 2023-02-02 20:21:17 +01:00
Andy Balaam e43d447535 Support MSC3946 in RoomCreate tile (#10041) 2023-02-02 13:39:13 +00:00
Andy Balaam b416e15cbd Tests for RoomListStore's predecessor handling (#10046) 2023-02-02 13:22:30 +00:00
Florian Duros 5b088f989f Update labs flag description for RTE (#10058) 2023-02-02 11:23:03 +01:00
Michael Telatynski 21c3967010 Revert "Member avatars without canvas" (#10057
* Revert "Apply more general fix for base avatar regressions (#10045)"

This reverts commit 371a3c0d36.

* Revert "Fix layout and visual regressions around default avatars (#10031)"

This reverts commit 0d1fce37b2.

* Revert "Member avatars without canvas (#9990)"

This reverts commit a8aa4de4b4.

* Update snapshots
2023-02-02 10:22:19 +00:00
Kerry 923ad4323b Poll history - setup labs setting (#10039)
* add settings while under development

* very basic tests for roomsummarycard

* empty poll history dialog and option in room summary

* pollS history in settings

* use more user-centric selectors in roomsummarycard test
2023-02-01 20:57:48 +00:00
Johannes Marbach 3766b39361 Merge branch 'develop' into johannes/latest-room-in-space 2023-02-01 19:54:40 +01:00
Andy Balaam 33b89a5709 Use Room.findPredecessor when rendering RoomCreate tiles (#10012)
* Use Room.findPredecessor to render RoomCreate tiles

* Handle state updates

* Handle missing predecessor

* Check for missing a room
2023-02-01 15:44:46 +00:00
Michael Weimann 7feb5b1f6b Add PiP move threshold (#10040) 2023-02-01 13:55:10 +01:00
Michael Weimann c6f6fa62f7 Implement broadcast UTD handling (#10021) 2023-02-01 13:32:49 +01:00
Florian Duros afda774471 Add RTE keyboard navigation in editing (#9980)
Add Keyboard navigation in editing
2023-02-01 13:12:12 +01:00
Germain 8161da1054 Remove threads beta feedback button (#10038) 2023-02-01 09:50:15 +00:00
Florian Duros 918f151384 Add indentation increasing/decreasing to RTE (#10034)
Add indent and unindent actions to RTE
2023-01-31 18:13:24 +01:00
Germain 703587b8e9 Cleanup pre MSC3773 thread unread notif logic (#10023) 2023-01-31 16:59:24 +00:00
Michael Telatynski 0d1fce37b2 Fix layout and visual regressions around default avatars (#10031) 2023-01-31 13:56:48 +00:00
grimhilt 5a08859e37 fix regional emojis converted to flags (#9294)
Co-authored-by: grimhilt <grimhilt@users.noreply.github.com>
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
Co-authored-by: Faye Duxovni <duxovni@duxovni.org>
Co-authored-by: Faye Duxovni <fayed@element.io>
Fixes https://github.com/vector-im/element-web/issues/19000
2023-01-31 13:08:35 +00:00
Michael Telatynski 262c2fcff2 Fix useUnreadNotifications exploding with falsey room, like in notif panel (#10030) 2023-01-31 12:38:25 +00:00
Clark Fischer 431afaafc6 Unify unread notification state determination (#9941)
* Add tests for unread notification facilities

Add some tests to guarantee some consistency in `useUnreadNotifications` and
`RoomNotificationState`.

Signed-off-by: Clark Fischer <clark.fischer@gmail.com>

* Add RoomNotifs#determineUnreadState

Intended as a singular replacement for the divergent implementations before.

Signed-off-by: Clark Fischer <clark.fischer@gmail.com>

* Unify room unread state determination

Have both the class-based facility and the hook use the new unified logic in
`RoomNotifs#determineUnreadState`.

Addresses https://github.com/vector-im/element-web/issues/24229

Signed-off-by: Clark Fischer <clark.fischer@gmail.com>

---------

Signed-off-by: Clark Fischer <clark.fischer@gmail.com>
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
2023-01-31 09:58:17 +00:00
Clark Fischer 53a9b6447b Fix MessageEditHistoryDialog crashing on complex input (#10018)
* noImplicitAny fixes for MessageDiffUtils

Signed-off-by: Clark Fischer <clark.fischer@gmail.com>

* Add tests for MessageDiffUtils

Adds mostly snapshot tests for MessageDiffUtils to guarantee consistent
behavior.

Signed-off-by: Clark Fischer <clark.fischer@gmail.com>

* Strict mode fixes for MessageDiffUtils

Gets `MessageDiffUtils` to pass under `tsc --strict`.

Fixes https://github.com/vector-im/element-web/issues/23665 - no longer errors,
though it still isn't correct.

Signed-off-by: Clark Fischer <clark.fischer@gmail.com>

* Remove obsolete DiffDOM workaround

Workaround is no longer necessary as of DiffDOM 4.2.1

See https://github.com/fiduswriter/diffDOM/issues/90

Signed-off-by: Clark Fischer <clark.fischer@gmail.com>

---------

Signed-off-by: Clark Fischer <clark.fischer@gmail.com>
2023-01-31 09:55:20 +00:00
Harnoor Singh 97f6431d60 Migrate highlight.js API call in TextualBody (#9923)
Co-authored-by: Michael Weimann <michaelw@matrix.org>
Fixes https://github.com/vector-im/element-web/issues/22233
2023-01-31 09:48:34 +00:00
Robin 43c67ce4bf Add ignore user confirmation dialog (#6116)
Signed-off-by: Robin Townsend <robin@robin.town>
2023-01-31 09:42:18 +00:00
Michael Weimann 269d1622b9 Implement more robust broadcast chunk header detection (#10006) 2023-01-31 09:48:30 +01:00
Germain e9d723269f Use CopyableText in devtools (#9993)
Co-authored-by: Alun Turner <alunt@element.io>
2023-01-30 17:01:54 +00:00
Clark Fischer 4c1e4f5127 Fix "[object Promise]" appearing in HTML exports (#9975)
Fixes https://github.com/vector-im/element-web/issues/24272
2023-01-30 14:31:32 +00:00
Germain 3e2bf5640e Update to supportsThreads (#9907) 2023-01-30 12:20:11 +00:00